Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DOMParser rules to search also outside the body tag #4070

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Fix DOMParser rules to search also outside the body tag #4070

merged 1 commit into from
Jan 7, 2021

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Jan 6, 2021

Description
Fixes #3984

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan merged commit 02725d8 into codeigniter4:develop Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: assertSee() can not assert title tag.
3 participants
@michalsn @samsonasik @paulbalandan